showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1032023101
##########
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##########
@@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {
}
@Override
- public Subscription buildSubscription(List<String> topics,
List<TopicPartition> partitions) {
- return new Subscription(topics, assignor.subscriptionUserData(new
HashSet<>(topics)), partitions);
+ public Subscription buildSubscriptionV0(List<String> topics,
List<TopicPartition> partitions, int generationId) {
+ // cooperative sticky assignor only supports
ConsumerProtocolSubscription V1 or above
+ return null;
Review Comment:
Thanks David, but in `testMemberDataFromSubscription` test, I did use `null`
check to make sure we will skip ConsumerProtocolSubscription v0 in
cooperativeStickyAssignor. We can throw exception here, but that would make the
test more complicated and that's unnecessary IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
