lucasbru commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1133769875


##########
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java:
##########
@@ -274,6 +282,13 @@ static public Serde<UUID> UUID() {
         return new UUIDSerde();
     }
 
+    /**
+     * A serde for nullable {@code Boolean} type.

Review Comment:
   The comment seems to give the impression that users can use the serde to 
represent `null`, `true` and `false`. I'm not sure if that is entirely true, 
since `null` has a special meaning in Kafka streams records. Maybe it's safer 
to drop the `nullable` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to