SpacRocket commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1144052014
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerde.java:
##########
@@ -48,42 +45,4 @@ public NullableValueAndTimestampSerde(final Serde<V>
valueSerde) {
);
}
- static final class BooleanSerde {
Review Comment:
I think not, I've found following unit tests that are using
NullableValueAndTimestampSerializer (currently the only code that depends on
BooleanSerde):
- NullableValueAndTimestampSerdeTest - These unit-tests check everything as
a whole class. There is not a single unit-test that tests only BooleanSerde.
- MeteredVersionedKeyValueStoreTest - Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
