SpacRocket commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1141463171
##########
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java:
##########
@@ -274,6 +282,13 @@ static public Serde<UUID> UUID() {
return new UUIDSerde();
}
+ /**
+ * A serde for nullable {@code Boolean} type.
Review Comment:
Thank you for the remark! What is wrong with having null for Boolean? I've
seen that other data types have it and Boolean type also supports it.
I've seen that SpotBugs also issues a warning for explicit null Boolean due
to auto-unboxing.
I think that for case when Serde shouldn't have Boolean nullable then I
should modify the code to return an exception when it's null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
