lucasbru commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1143171856
##########
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java:
##########
@@ -274,6 +282,13 @@ static public Serde<UUID> UUID() {
return new UUIDSerde();
}
+ /**
+ * A serde for nullable {@code Boolean} type.
Review Comment:
I checked again, and I guess you don't have to worry too much about my
concern. When I read that comment you wrote, I understand "this class turns
`true`, `false`, `null` into a byte array", but it actually maps `null` to
`null` and the caller has to find a way how to deal with the `null` result.
This seems like this is a convention generally in KStreams, so I think the code
is fine, I was just worried about giving the wrong impression to as user of
this function, but, as I said, probably safe to ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
