abhijeetk88 commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1257340916
########## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ########## @@ -158,23 +164,34 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig, String logDir, String clusterId, Time time, - Function<TopicPartition, Optional<UnifiedLog>> fetchLog) { + Function<TopicPartition, Optional<UnifiedLog>> fetchLog, + BrokerTopicStats brokerTopicStats) { this.rlmConfig = rlmConfig; this.brokerId = brokerId; this.logDir = logDir; this.clusterId = clusterId; this.time = time; this.fetchLog = fetchLog; + this.brokerTopicStats = brokerTopicStats; remoteLogStorageManager = createRemoteStorageManager(); remoteLogMetadataManager = createRemoteLogMetadataManager(); indexCache = new RemoteIndexCache(1024, remoteLogStorageManager, logDir); delayInMs = rlmConfig.remoteLogManagerTaskIntervalMs(); rlmScheduledThreadPool = new RLMScheduledThreadPool(rlmConfig.remoteLogManagerThreadPoolSize()); + + metricsGroup.newGauge("RemoteLogManagerTasksAvgIdlePercent", new Gauge<Double>() { Review Comment: Closed the metrics and added tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org