jeqo commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1261114941
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -277,6 +277,12 @@ class BrokerTopicMetrics(name: Option[String]) {
BrokerTopicStats.TotalFetchRequestsPerSec ->
MeterWrapper(BrokerTopicStats.TotalFetchRequestsPerSec, "requests"),
BrokerTopicStats.FetchMessageConversionsPerSec ->
MeterWrapper(BrokerTopicStats.FetchMessageConversionsPerSec, "requests"),
BrokerTopicStats.ProduceMessageConversionsPerSec ->
MeterWrapper(BrokerTopicStats.ProduceMessageConversionsPerSec, "requests"),
+ BrokerTopicStats.RemoteCopyBytesPerSec ->
MeterWrapper(BrokerTopicStats.RemoteCopyBytesPerSec, "bytes"),
+ BrokerTopicStats.RemoteFetchBytesPerSec ->
MeterWrapper(BrokerTopicStats.RemoteFetchBytesPerSec, "bytes"),
+ BrokerTopicStats.RemoteReadRequestsPerSec ->
MeterWrapper(BrokerTopicStats.RemoteReadRequestsPerSec, "requests"),
+ BrokerTopicStats.RemoteWriteRequestsPerSec ->
MeterWrapper(BrokerTopicStats.RemoteWriteRequestsPerSec, "requests"),
+ BrokerTopicStats.FailedRemoteReadRequestsPerSec ->
MeterWrapper(BrokerTopicStats.FailedRemoteReadRequestsPerSec, "requests"),
+ BrokerTopicStats.FailedRemoteWriteRequestsPerSec ->
MeterWrapper(BrokerTopicStats.FailedRemoteWriteRequestsPerSec, "requests"),
Review Comment:
I was suspecting this would be the case. Though as metrics haven't been
implemented yet, would it be possible to amend the KIP and ask for feedback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
