[GitHub] [kafka] jeqo commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

[via GitHub]

jeqo commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1258934931


##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -277,6 +277,12 @@ class BrokerTopicMetrics(name: Option[String]) {
     BrokerTopicStats.TotalFetchRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.TotalFetchRequestsPerSec, "requests"),
     BrokerTopicStats.FetchMessageConversionsPerSec -> 
MeterWrapper(BrokerTopicStats.FetchMessageConversionsPerSec, "requests"),
     BrokerTopicStats.ProduceMessageConversionsPerSec -> 
MeterWrapper(BrokerTopicStats.ProduceMessageConversionsPerSec, "requests"),
+    BrokerTopicStats.RemoteCopyBytesPerSec -> 
MeterWrapper(BrokerTopicStats.RemoteCopyBytesPerSec, "bytes"),
+    BrokerTopicStats.RemoteFetchBytesPerSec -> 
MeterWrapper(BrokerTopicStats.RemoteFetchBytesPerSec, "bytes"),
+    BrokerTopicStats.RemoteReadRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.RemoteReadRequestsPerSec, "requests"),
+    BrokerTopicStats.RemoteWriteRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.RemoteWriteRequestsPerSec, "requests"),
+    BrokerTopicStats.FailedRemoteReadRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.FailedRemoteReadRequestsPerSec, "requests"),
+    BrokerTopicStats.FailedRemoteWriteRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.FailedRemoteWriteRequestsPerSec, "requests"),

Review Comment:
   few more naming suggestions:
   
   ```suggestion
       BrokerTopicStats.RemoteFetchRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.RemoteFetchRequestsPerSec, "requests"),
       BrokerTopicStats.RemoteCopyRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.RemoteCopyRequestsPerSec, "requests"),
       BrokerTopicStats.FailedRemoteCopyRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.FailedRemoteFetchRequestsPerSec, "requests"),
       BrokerTopicStats.FailedRemoteCopyRequestsPerSec -> 
MeterWrapper(BrokerTopicStats.FailedRemoteCopyRequestsPerSec, "requests"),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org