divijvaidya commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1261098919
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -277,6 +277,12 @@ class BrokerTopicMetrics(name: Option[String]) {
BrokerTopicStats.TotalFetchRequestsPerSec ->
MeterWrapper(BrokerTopicStats.TotalFetchRequestsPerSec, "requests"),
BrokerTopicStats.FetchMessageConversionsPerSec ->
MeterWrapper(BrokerTopicStats.FetchMessageConversionsPerSec, "requests"),
BrokerTopicStats.ProduceMessageConversionsPerSec ->
MeterWrapper(BrokerTopicStats.ProduceMessageConversionsPerSec, "requests"),
+ BrokerTopicStats.RemoteCopyBytesPerSec ->
MeterWrapper(BrokerTopicStats.RemoteCopyBytesPerSec, "bytes"),
+ BrokerTopicStats.RemoteFetchBytesPerSec ->
MeterWrapper(BrokerTopicStats.RemoteFetchBytesPerSec, "bytes"),
+ BrokerTopicStats.RemoteReadRequestsPerSec ->
MeterWrapper(BrokerTopicStats.RemoteReadRequestsPerSec, "requests"),
+ BrokerTopicStats.RemoteWriteRequestsPerSec ->
MeterWrapper(BrokerTopicStats.RemoteWriteRequestsPerSec, "requests"),
+ BrokerTopicStats.FailedRemoteReadRequestsPerSec ->
MeterWrapper(BrokerTopicStats.FailedRemoteReadRequestsPerSec, "requests"),
+ BrokerTopicStats.FailedRemoteWriteRequestsPerSec ->
MeterWrapper(BrokerTopicStats.FailedRemoteWriteRequestsPerSec, "requests"),
Review Comment:
Note that the KIP version was voted with the earlier names and now changing
the KIP would be equivalent to breaking the agreed contract when the KIP was
accepted. I will propose to keep the metric names as they were in the KIP. If
we want to introduce new ones, we can start a new KIP which deprecates these
metrics and uses new ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
