abhijeetk88 commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1264719933
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -589,6 +687,47 @@ void testIdempotentClose() throws IOException {
inorder.verify(remoteLogMetadataManager, times(1)).close();
}
+ @Test
+ public void testRemoveMetricsOnClose() {
+ MockedConstruction<KafkaMetricsGroup> mockMetricsGroupCtor =
mockConstruction(KafkaMetricsGroup.class);
+ try {
+ RemoteLogManager remoteLogManager = new
RemoteLogManager(remoteLogManagerConfig, brokerId, logDir, clusterId,
+ time, tp -> Optional.of(mockLog), brokerTopicStats) {
+ public RemoteStorageManager createRemoteStorageManager() {
+ return remoteStorageManager;
+ }
+
+ public RemoteLogMetadataManager
createRemoteLogMetadataManager() {
+ return remoteLogMetadataManager;
+ }
+ };
+ // Close RemoteLogManager so that metrics are removed
+ remoteLogManager.close();
+
+ KafkaMetricsGroup mockRlmMetricsGroup =
mockMetricsGroupCtor.constructed().get(0);
+ KafkaMetricsGroup mockThreadPoolMetricsGroup =
mockMetricsGroupCtor.constructed().get(1);
+
+ List<String> remoteLogManagerMetricNames =
Collections.singletonList(REMOTE_LOG_MANAGER_TASKS_AVG_IDLE_PERCENT);
+ List<String> remoteStorageThreadPoolMetricNames = Arrays.asList(
Review Comment:
Addressed.
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -894,6 +920,7 @@ public void close() {
Utils.closeQuietly(indexCache, "RemoteIndexCache");
rlmScheduledThreadPool.close();
+ removeMetrics();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
