lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1337309504
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -58,7 +59,7 @@
public class HeartbeatRequestManagerTest {
Review Comment:
High level comment, I do see this test covering the timing logic for
sending, and the response handling on error, but nothing for the successful HB
response handling (important to ensure that it is updating the target
assignment so that it can be processed by other components). Also it would be
helpful to have some tests around HB timeouts, mainly to validate the retry
logic around that.
(Just suggestions for better coverage of core actions, OK for me if we
prefer to target that in a separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
