hanyuzheng7 commented on code in PR #14523:
URL: https://github.com/apache/kafka/pull/14523#discussion_r1360875255
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##########
@@ -1071,16 +1568,51 @@ public <V> void shouldHandleKeyQuery(
assertThrows(IllegalArgumentException.class,
queryResult::getFailureReason);
assertThrows(
- IllegalArgumentException.class,
- queryResult::getFailureMessage
+ IllegalArgumentException.class,
+ queryResult::getFailureMessage
);
final V result1 = queryResult.getResult();
final Integer integer = valueExtactor.apply(result1);
assertThat(integer, is(expectedValue));
assertThat(queryResult.getExecutionInfo(), is(empty()));
assertThat(queryResult.getPosition(), is(POSITION_0));
- }
+ }
+
+ public <V> void shouldHandleKeyPAPIQuery(
Review Comment:
At this time, these two methods are the same. We can use one method to
handle both topologies. So we can use shouldHandleKeyQuery one to handle two
topologies. I will update it.
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##########
@@ -655,7 +657,7 @@ public void process(final Record<Integer, Integer> record) {
ValueAndTimestamp.make(
record.value(), record.timestamp()
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
