mjsax commented on code in PR #14523:
URL: https://github.com/apache/kafka/pull/14523#discussion_r1357200115
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##########
@@ -880,25 +888,113 @@ private <T> void shouldHandleWindowKeyQueries(final
Function<T, Integer> extract
extractor,
mkSet()
);
+
+ shouldHandleWindowKeyQuery(
Review Comment:
Thanks. Maybe add some (short) comment about it similar to the existing test
cases.
The "confusing" thing is, that the bounds are not "strict": for example you
use range 4 to 11, what gives the same result at 5 to 11, or 4 to 10.... (so
why is 4,11 used but not some other bound? if it's random, also ok, but should
be clarified). For testing, the interesting part is usually when "bounds" are
crossed:
For example, we could have a query range 5,9 that only returns the window
starting at 5, plus range 5,10 that returns two windows (thus we test the upper
bound from 9 and 10), plus range 6,10 that would only return the window at 10
(and thus verify the lower bound from 5 to 6). Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
