hanyuzheng7 commented on code in PR #14523:
URL: https://github.com/apache/kafka/pull/14523#discussion_r1357233277
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##########
@@ -863,6 +863,14 @@ private <T> void shouldHandleWindowKeyQueries(final
Function<T, Integer> extract
mkSet()
);
+ shouldHandleWindowKeyQuery(
+ 2,
Review Comment:
```
// tightest possible start range
shouldHandleWindowKeyQuery(
2,
Instant.ofEpochMilli(WINDOW_START),
Instant.ofEpochMilli(WINDOW_START),
extractor,
mkSet()
);
```
this test comment maybe change to cannot find key 2 at first window
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##########
@@ -863,6 +863,14 @@ private <T> void shouldHandleWindowKeyQueries(final
Function<T, Integer> extract
mkSet()
);
+ shouldHandleWindowKeyQuery(
+ 2,
Review Comment:
```
// tightest possible start range
shouldHandleWindowKeyQuery(
2,
Instant.ofEpochMilli(WINDOW_START),
Instant.ofEpochMilli(WINDOW_START),
extractor,
mkSet()
);
```
this test comment maybe change to cannot find key 2 at first window
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
