soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1371372722
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -54,6 +54,7 @@ public static boolean
changeRecordIsNoOp(PartitionChangeRecord record) {
if (record.removingReplicas() != null) return false;
if (record.addingReplicas() != null) return false;
if (record.leaderRecoveryState() != LeaderRecoveryState.NO_CHANGE)
return false;
+ if (record.assignment() != null) return false;
Review Comment:
I had addressed that and lots of other references to `Replicas` in #14516
https://github.com/apache/kafka/pull/14516/files#diff-61a58fedae1bdadb73928dd41ccc4eeffe47d599557ad2b2973e3124d38e3d44R191-R196
Would it be preferable to join the two PRs in a single patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
