rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1371865719
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -54,6 +54,7 @@ public static boolean
changeRecordIsNoOp(PartitionChangeRecord record) {
if (record.removingReplicas() != null) return false;
if (record.addingReplicas() != null) return false;
if (record.leaderRecoveryState() != LeaderRecoveryState.NO_CHANGE)
return false;
+ if (record.assignment() != null) return false;
Review Comment:
> Would it be preferable to join the two PRs in a single patch?
They are related for sure. I assume the changes specific to that other PR
would be much smaller if we decided to abandon the `Assignment` of type
`[]ReplicaAssignment` in favor of just an array of UUIDs. Then the changes
would just be specific to that which is required for JBOD as opposed to all the
changes related to a wholesale replacement of `Replicas []int32` with
`Assignment []ReplicaAssignment`. My preference right now would be to abandon
`[]ReplicaAssignment` and include the then-smaller changes from that other PR
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
