kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386913209
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1893,8 +2014,9 @@ private void consumerCloseTest(final long closeTimeoutMs,
}
}
- @Test
- public void testPartitionsForNonExistingTopic() {
+ @ParameterizedTest
+ @MethodSource("genericGroupProtocolOnly")
+ public void testPartitionsForNonExistingTopic(GroupProtocol groupProtocol)
{
Review Comment:
Most, yes. There are some `enforceRebalance()` tests which—as I understand
it—don't make sense to "port" over to the new group protocol.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1893,8 +2014,9 @@ private void consumerCloseTest(final long closeTimeoutMs,
}
}
- @Test
- public void testPartitionsForNonExistingTopic() {
+ @ParameterizedTest
+ @MethodSource("genericGroupProtocolOnly")
+ public void testPartitionsForNonExistingTopic(GroupProtocol groupProtocol)
{
Review Comment:
Most, yes. There are some `enforceRebalance()` tests which—as I understand
it—don't make sense to "port" over to the new group protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
