cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414713000
##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -347,7 +347,7 @@ private void maybePublishMetadata(MetadataDelta delta,
MetadataImage image, Load
}
metrics.updateLastAppliedImageProvenance(image.provenance());
metrics.setCurrentMetadataVersion(image.features().metadataVersion());
- if (uninitializedPublishers.isEmpty()) {
+ if (!uninitializedPublishers.isEmpty()) {
Review Comment:
Sigh. Looks like this was introduced in KAFKA-14538, which I reviewed. It
really only bites in scenarios where you're running a pre-NO_OP record MV,
which is rare these days.
Thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
