lucasbru commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416992430
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -198,6 +219,17 @@ public long maximumTimeToWait(long currentTimeMs) {
return heartbeatNow ? 0L :
heartbeatRequestState.nextHeartbeatMs(currentTimeMs);
}
+ /**
+ * When consumer polls, we need to reset the pollTimer. If member is
already leaving the group
+ */
+ public void ack() {
+ pollTimer.reset(rebalanceTimeoutMs);
+ }
+
+ Timer pollTimer() {
Review Comment:
I was assuming that after passing the poll timer from the outside, we don't
need to make this visible for testing anymore
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##########
@@ -137,4 +142,15 @@ public interface MembershipManager {
* Note that list of topics of the subscription is taken from the shared
subscription state.
*/
void onSubscriptionUpdated();
+
+ /**
+ * Transition to the {@link MemberState#JOINING} state to attempt joining
a group.
+ */
+ void transitionToJoining();
+
+ /**
+ * When the user stops polling the consumer, the member will be
transitioned to LEAVING without revoking the
Review Comment:
How does the comment about `LEAVING` relate to this method? Maybe needs to
be updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
