lianetm commented on code in PR #14873: URL: https://github.com/apache/kafka/pull/14873#discussion_r1416605360
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ########## @@ -103,6 +103,12 @@ public class HeartbeatRequestManager implements RequestManager { */ private final BackgroundEventHandler backgroundEventHandler; + /** + * Timer for tracking the time since the last consumer poll. If the timer expires, the consumer will stop + * sending heartbeat until the next poll. + */ Review Comment: My take is that we should always send the leave group when the poll timer expires (group.instance.id null or not). Dynamic members should send -1 and static -2 as described in the KIP. The [documentation of the max.poll.interval](https://kafka.apache.org/documentation/#consumerconfigs_max.poll.interval.ms) is just describing what will happen on the broker side (if static member leaving, broker won't re-assign the partitions until the session timeout expires. If dynamic member, it will re-assign them right away). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org