philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432199044
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -728,7 +732,6 @@ public boolean shouldSkipHeartbeat() {
@Override
public void transitionToStaled() {
memberEpoch = ConsumerGroupHeartbeatRequest.LEAVE_GROUP_MEMBER_EPOCH;
- currentAssignment.clear();
Review Comment:
See the TODO on line 676. For now, I think we can directly clear the
currentAssignment and remove owned partitions. In the future, we will need to
wait for the callback to complete before proceed with joining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
