philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432202539
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -234,7 +237,8 @@ public long maximumTimeToWait(long currentTimeMs) {
* When consumer polls, we need to reset the pollTimer. If the poll timer
has expired, we rejoin only when the
* member is in the {@link MemberState#UNSUBSCRIBED} state.
*/
- public void resetPollTimer() {
+ public void resetPollTimer(final long pollMs) {
+ pollTimer.update(pollMs);
Review Comment:
note: pollMs is the time user invoke consumer#poll. This is better than
taking time.millisecond() because there could be some discrepancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
