johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527553634
##########
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##########
@@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,
MetricValueProvider<?> va
this.time = time;
}
+ /**
+ * Get the configuration of this metric
+ * @return Return the config of this metric
+ */
public MetricConfig config() {
- return this.config;
+ synchronized (lock) {
Review Comment:
sure, let me address this. I think you are right, this is a different issue.
Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
