chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1530224467


##########
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##########
@@ -78,6 +111,10 @@ public Measurable measurable() {
         }
     }
 
+    /**
+     * Set the metric config.

Review Comment:
   > However, why are users not allowed to fetch the config?
   
   `MetricConfig` has the methods used by server too, so encouraging user to 
access `MetricConfig` could lead potential trouble I feel.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to