chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527554674
##########
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##########
@@ -78,6 +111,10 @@ public Measurable measurable() {
}
}
+ /**
+ * Set the metric config.
Review Comment:
This method normally is used to update quota and it should be used by
server-side only. Could you add comments to remind `MetricsReporter` users that
they should NOT call this method? ditto for `config()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
