chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1533141970
##########
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##########
@@ -40,15 +48,29 @@ public KafkaMetric(Object lock, MetricName metricName,
MetricValueProvider<?> va
this.time = time;
}
+ /**
+ * Get the configuration of this metric.
+ * This is supposed to be used by server only.
Review Comment:
@mimaison it seems to me those methods are used by server to "write"
something (for example, quota), and so users should view the metrics as
readonly object. Please correct me If I misunderstand the purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
