chickenchickenlove opened a new pull request, #15573: URL: https://github.com/apache/kafka/pull/15573
This is minor changes! - Jira : https://issues.apache.org/jira/browse/KAFKA-15951 - `MissingSourceTopicException` has field `missingTopics` to store missing topics. - The `StreamsPartitionAssignor` throws a `MissingSourceTopicException`. and it depends on result of `repartitionTopics.missingSourceTopicExceptions().isEmpty()`. thus, `missingSourceTopicExceptions()` must always contain an iterable `MissingSourceTopicException`, allowing for the aggregation and throwing of `MissingSourceTopics`. - Idea for improving more - `StreamsRebalanceListener` can throw `MissingSourceTopicException` as well. however, `StreamsRebalanceListener` cannot get missing topic List because `StreamsRebalanceListener` depends on ErrorCode `AssignorError.INCOMPLETE_SOURCE_TOPIC_METADATA.code()` - If `StreamsRebalanceListener` should include missing topic list when it throws `MissingSourceTopicException` as well, we can consider `ThreadLocal` to reach the target. - Skeleton - Set `ThreadLocal` to `StreamThread` as member field. - Put missing topics to `ThreadLocal`. - `StreamsRebalanceListener` can get missing topics through `ThreadLocal`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
