chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1537690828


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java:
##########
@@ -119,7 +119,8 @@ public Queue<StreamsException> 
missingSourceTopicExceptions() {
             return new StreamsException(
                 new MissingSourceTopicException(String.format(
                     "Missing source topics %s for subtopology %d of topology 
%s",
-                    missingSourceTopics, subtopologyId, topologyName)),
+                    missingSourceTopics, subtopologyId, topologyName),
+                    missingSourceTopics),

Review Comment:
   FYI, i write skeleton code below! 
   Does it make sense to you as well?
   ```java
   public class RepartitionTopics {
       ...
       // Add new field (private)
       private final Set<String> missingTopics = new HashSet(); 
   
       ...
       public Set<String> topologiesWithMissingInputTopics() { ... }
       public Queue<StreamsException> missingSourceTopicExceptions() { ... }
   
       // Add new method (package-private)
       Set<String> getMissingTopics() {
         return this.missingTopics;
       }
      ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to