cadonna commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1538819784
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java:
##########
@@ -119,7 +119,8 @@ public Queue<StreamsException>
missingSourceTopicExceptions() {
return new StreamsException(
new MissingSourceTopicException(String.format(
"Missing source topics %s for subtopology %d of topology
%s",
- missingSourceTopics, subtopologyId, topologyName)),
+ missingSourceTopics, subtopologyId, topologyName),
+ missingSourceTopics),
Review Comment:
The public interface is defined as everything that shows up in the
[javadocs](https://kafka.apache.org/37/javadoc/). Classes in a package whose
name contains `internals` do not show up in the javadocs. Class
`RepartitionTopics` is in package
`org.apache.kafka.streams.processor.internals`. Thus, `RepartitionTopics` is
not part of the public interface.
Regarding field `missingTopics`, there is already
`missingInputTopicsBySubtopology` that includes all missing topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
