chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1537649345
##########
streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java:
##########
@@ -16,11 +16,25 @@
*/
package org.apache.kafka.streams.errors;
+import java.util.HashSet;
+import java.util.Set;
+
public class MissingSourceTopicException extends StreamsException {
private final static long serialVersionUID = 1L;
+ private final Set<String> missingTopics;
public MissingSourceTopicException(final String message) {
super(message);
+ this.missingTopics = new HashSet<>();
+ }
+
+ public MissingSourceTopicException(final String message, final Set<String>
missingTopics) {
+ super(message);
+ this.missingTopics = missingTopics;
+ }
+
+ public Set<String> getMissingTopics() {
+ return this.missingTopics;
Review Comment:
Hi, @cadonna. Thanks for your comment and your time. 🙇♂️
It is very helpful for me, and i feel quite sorry to make you spend a lot of
time for me.
After reading the KIP document, now i can tell public interface should be
introduced carefully!
I have a comment to make new commit to apply your comment.
When you have some free time, could you take a look? it will be very helpful
for me. 🙇♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
