cadonna commented on PR #15640: URL: https://github.com/apache/kafka/pull/15640#issuecomment-2084906500
> > Here I have a comment, I could not put at the right location in the code: > > On line 1362, in `commitSync()` the consumer waits on the `commitFuture` with a timer. I think, it should not wait on a timer there since we already wait on a timer in the background thread. > > I agree. What about the timed wait in `awaitPendingAsyncCommitsAndExecuteCommitCallbacks()`? Do you have something in mind? Like using the `commitFuture` as a timeout for the awaiting of the execution of the callback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
