kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1583452722
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -946,8 +907,7 @@ public Map<TopicPartition, OffsetAndMetadata>
committed(final Set<TopicPartition
timer);
Review Comment:
Agreed. Using the deadline directly instead of a `Timer`.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1026,7 +986,7 @@ public Map<String, List<PartitionInfo>>
listTopics(Duration timeout) {
final AllTopicsMetadataEvent topicMetadataEvent = new
AllTopicsMetadataEvent(timer);
Review Comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
