cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684609938
########## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ########## @@ -221,7 +230,7 @@ private void maybeLoadLog() { } private void maybeLoadSnapshot() { - if ((nextOffset == 0 || nextOffset < log.startOffset()) && log.latestSnapshot().isPresent()) { + if ((nextOffset == -1 || nextOffset < log.startOffset()) && log.latestSnapshot().isPresent()) { Review Comment: same, let's use the constant ########## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ########## @@ -254,6 +263,10 @@ private void maybeLoadSnapshot() { nextOffset = reader.lastContainedLogOffset() + 1; } + } else if (nextOffset == -1) { Review Comment: same, let's use the constant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org