jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684705773
##########
raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java:
##########
@@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {
//
// 2. The read operations lastVoterSet, voterSetAtOffset and
kraftVersionAtOffset read
// the nextOffset first before reading voterSetHistory or
kraftVersionHistory
- private volatile long nextOffset = 0;
+ private volatile long nextOffset = -1;
Review Comment:
Done. I redefined those values in ListenerContext and
KRaftControlRecordStateMachine. I'll share the definition is a future PR when I
refactor KafkaRaftClient and unified the controller/broker listener logic and
the internal listener logic.
I didn't want to do this right away since the `git diff` would be too big.
The controller/broker listeners are interested in committed state while the
internal listener is interested in all of the state (committed and uncommitted).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
