apoorvmittal10 commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1792045275
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig {
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1),
MEDIUM,
- GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC);
+ GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_RECORD_LOCK_DURATION_MS_CONFIG,
+ INT,
+ ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT,
+ atLeast(1),
Review Comment:
Yeah you. have to be consistent with values defined in the KIP.
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1716,7 +1725,17 @@ private KafkaException fetchPersisterError(short
errorCode, String errorMessage)
}
}
- private AcquisitionLockTimerTask scheduleAcquisitionLockTimeout(String
memberId, long firstOffset, long lastOffset) {
+ // Visible for Testing
Review Comment:
nit
```suggestion
// Visible for testing
```
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -159,7 +160,9 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
throw new InvalidRequestException("Group name must not be empty")
} else {
val groupProps = configRepository.groupConfig(group)
- val groupConfig =
GroupConfig.fromProps(config.groupCoordinatorConfig.extractGroupConfigMap,
groupProps)
+ val defaultConfigs: util.Map[String, Integer] =
config.groupCoordinatorConfig.extractConsumerGroupConfigMap()
+
defaultConfigs.putAll(config.shareGroupConfig.extractShareGroupConfigMap())
+ val groupConfig = GroupConfig.fromProps(defaultConfigs,
groupProps)
Review Comment:
Ok, will wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
