AndrewJSchofield commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1793213402
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig {
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1),
MEDIUM,
- GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC);
+ GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_RECORD_LOCK_DURATION_MS_CONFIG,
+ INT,
+ ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT,
+ atLeast(1000),
Review Comment:
There is a hierarchy of configs to bear in mind, as described in KIP-932.
The broker config `group.share.record.lock.duration.ms` is the default
duration when there is no group-specific configuration. This one should be
`between(1000, 60000)`. Most groups will use this config.
The broker configs `group.share.min.record.lock.duration.ms` and
`group.share.max.record.lock.duration.ms` control the broker's min and max
which are used to bound group-specific configuration of the lock duration.
Static validation of `atLeast(1000)` is certainly not wrong but the majority of
the validation is dynamic in the `validateValues(,,)` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
