chirag-wadhwa5 commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1793749856
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -194,7 +194,8 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
val allSynonyms = {
val list = configSynonyms(name, allNames, isSensitive)
if (!groupProps.containsKey(name))
- list
+ new
DescribeConfigsResponseData.DescribeConfigsSynonym().setName(name).setValue(valueAsString)
Review Comment:
Thanks for the review, We need this change because when we do a
kafka-configs.sh describe command with --all option, ideally it should display
all the configs present in the GroupConfig file and the synonym field should
display the source of the config, either it should be `DEFAULT_CONFIG` or
`DYNAMIC_GROUP_CONFIG`. But, without this change, it was only displaying the
configs, the source for which was `DYNAMIC_GROUP_CONFIG`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
