chia7712 commented on code in PR #17331:
URL: https://github.com/apache/kafka/pull/17331#discussion_r1793102824
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig {
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1),
MEDIUM,
- GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC);
+ GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_RECORD_LOCK_DURATION_MS_CONFIG,
+ INT,
+ ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT,
+ atLeast(1000),
Review Comment:
Apologies, but in `ShareGroupConfig`, the validator for
`SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG` is set to `between(1000, 60000)`,
while in `GroupConfig` there’s no upper bound. Why is that?
Additionally, the validator `between(1000, 60000)` seems odd, given that the
upper bound for `SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_CONFIG` is `3600000`.
Shouldn't the correct validator be `between(1000, 3600000)`?
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -351,6 +353,9 @@ class BrokerServer(
tokenManager = new DelegationTokenManager(config, tokenCache, time)
tokenManager.startup()
+ /* initializing the groupConfigManager */
+ groupConfigManager = new
GroupConfigManager(config.groupCoordinatorConfig.extractGroupConfigMap(config.shareGroupConfig))
Review Comment:
`GroupConfigManager` has `close` method, so I guess it should be executed
when closing `BrokerServer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
