apoorvmittal10 commented on code in PR #17437:
URL: https://github.com/apache/kafka/pull/17437#discussion_r1795049346
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1810,7 +1811,7 @@ &&
checkForStartOffsetWithinBatch(inFlightBatch.firstOffset(), inFlightBatch.las
// If we have an acquisition lock timeout for a
share-partition, then we should check if
// there is a pending share fetch request for the
share-partition and complete it.
DelayedShareFetchKey delayedShareFetchKey = new
DelayedShareFetchGroupKey(groupId, topicIdPartition.topicId(),
topicIdPartition.partition());
-
delayedShareFetchPurgatory.checkAndComplete(delayedShareFetchKey);
+
replicaManager.completeDelayedShareFetchRequest(delayedShareFetchKey);
Review Comment:
If there happens to be a function/callback defined in SharePartitionManager
which accepts `delayedShareFetchKey` then that method can be re-used at other
places as well where we want to invoke replica manager API calls.
I would suggest the least dependency of scala classes in other classes so we
can move them from core to share module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
