adixitconfluent commented on PR #17437: URL: https://github.com/apache/kafka/pull/17437#issuecomment-2411772927
>This is not an area of code that I know in depth, so I'll not approve it. I wonder whether the fact that topic ID is generally Option[Uuid] will mean that the purgatory operations will not always have the topic ID present, and thus might not be able to complete in all cases. Is this a real concern? Hi @AndrewJSchofield, `checkAndComplete` provide a quicker way of checking if a watched task in the purgatory can be completed at that instant. Anyways, that task will be completed when the timeout occurs for the purgatory entry which will occur post `maxWaitMs`. IMO, in case the topic ID is not present, then the performance will be impacted slightly but definitely not reliability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
