AndrewJSchofield commented on code in PR #17437: URL: https://github.com/apache/kafka/pull/17437#discussion_r1795131090
########## core/src/main/java/kafka/server/share/DelayedShareFetchPartitionKey.java: ########## @@ -18,19 +18,21 @@ import kafka.server.DelayedOperationKey; -import org.apache.kafka.common.Uuid; - import java.util.Objects; /** - * A key for delayed share fetch purgatory that refers to the topic partition. + * A key for delayed share fetch purgatory that refers to the topic partition. Since the below replicaManager functionalities + * use TopicPartition and not TopicIdPartition, hence we are using the same here. Review Comment: I agree. In general, all new code that uses topics should use topic ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
