adixitconfluent commented on PR #17437: URL: https://github.com/apache/kafka/pull/17437#issuecomment-2408877802
Hi @junrao , I've shifted back to using `TopicId` instead of `TopicName` for `DelayedShareFetchPartitionKey`. IIUC, not all functionalities of `ReplicaManager` and `Partition` use `TopicId`. I've tried to incorporate it where I found it. I saw a JIRA related to adding topicIds in `ReplicaManager` functionalities https://issues.apache.org/jira/browse/KAFKA-16212. I've added a [TODO](https://github.com/apache/kafka/pull/17437/files#diff-78812e247ffeae6f8c49b1b22506434701b1e1bafe7f92ef8f8708059e292bf0R986) in my PR where there will be a need to add `delayedShareFetchPurgatory.checkAndComplete` once `ReplicaManager.appendRecords` has support for topicIds. Let me know if I should create a general JIRA for that. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
