kevin-wu24 commented on code in PR #17528:
URL: https://github.com/apache/kafka/pull/17528#discussion_r1806841892
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java:
##########
@@ -202,13 +202,8 @@ public void testReadWhenNoMaxPosition(boolean
minOneMessage) throws IOException
MemoryRecords ms = records(50, "hello", "there");
seg.append(51, RecordBatch.NO_TIMESTAMP, -1L, ms);
- // read before first offset
Review Comment:
Not sure if this case is relevant. There's only 1 batch which starts at
offset 50, so the returned `LogOffsetMetadata` has an offset field of 50 rather
than 48. Under `LogSegment#read`'s previous behavior, offset 48 is just
directly returned, so I don't think this case is actually doing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
