kevin-wu24 commented on code in PR #17528:
URL: https://github.com/apache/kafka/pull/17528#discussion_r1823600140
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java:
##########
@@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String...
records) {
Compression.NONE, TimestampType.CREATE_TIME,
simpleRecords.toArray(new SimpleRecord[0]));
}
+ private MemoryRecords makeBatch(long offset, String... records) {
Review Comment:
It looks like the other `records(offset, size)` method signature being used
in `testAppendFromFile` is slightly misleading. `size` is not actually the
number of records to add in a batch, but rather the size of a single record for
a specified offset. I'll still rename `records(offset, records...)` and
`makeBatch` to `v1Records` and `v2Records`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
