junrao commented on code in PR #17528:
URL: https://github.com/apache/kafka/pull/17528#discussion_r1823113684
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##########
@@ -409,17 +409,17 @@ public FetchDataInfo read(long startOffset, int maxSize,
long maxPosition) throw
}
/**
- * Read a message set from this segment beginning with the first offset >=
startOffset. The message set will include
+ * Read a message set from this segment that contains startOffset. The
message set will include
* no more than maxSize bytes and will end before maxOffset if a maxOffset
is specified.
*
* This method is thread-safe.
*
- * @param startOffset A lower bound on the first offset to include in the
message set we read
+ * @param startOffset The logical log offset we are trying to read, which
is a lower bound when startOffset is the base offset of a batch
Review Comment:
It's probably simpler to just say "The logical log offset we are trying to
read".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
