junrao commented on code in PR #17528:
URL: https://github.com/apache/kafka/pull/17528#discussion_r1823516406
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java:
##########
@@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String...
records) {
Compression.NONE, TimestampType.CREATE_TIME,
simpleRecords.toArray(new SimpleRecord[0]));
}
+ private MemoryRecords recordsOneBatch(long offset, String... records) {
Review Comment:
recordsOneBatch => makeBatch ?
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java:
##########
@@ -164,6 +174,21 @@ public void testReadBeforeFirstOffset() throws IOException
{
}
}
+ /**
+ * Reading from an offset is in the middle of a batch should return a
Review Comment:
an offset is in the middle => an offset in the middle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
