mimaison commented on code in PR #18016:
URL: https://github.com/apache/kafka/pull/18016#discussion_r1867829179
##########
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java:
##########
@@ -115,9 +115,6 @@ private void publishDelta(MetadataDelta delta) {
}
Review Comment:
We still have ZK_MIGRATION_STATE and MIGRATING_ZK_BROKER_COUNT defined in
ControllerMetadataMetrics. Should we delete these too?
##########
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##########
@@ -247,8 +246,7 @@ public void replay(ApiMessage record) {
*/
break;
case ZK_MIGRATION_STATE_RECORD:
- replay((ZkMigrationStateRecord) record);
- break;
+ throw new UnsupportedOperationException("ZK migration is no
longer support.");
Review Comment:
`supported`
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1250,8 +1248,7 @@ private void replay(ApiMessage message,
Optional<OffsetAndEpoch> snapshotId, lon
// NoOpRecord is an empty record and doesn't need to be
replayed
break;
case ZK_MIGRATION_STATE_RECORD:
- featureControl.replay((ZkMigrationStateRecord) message);
- break;
+ throw new UnsupportedOperationException("ZK migration is no
longer support.");
Review Comment:
`support` -> `supported`
##########
core/src/main/scala/kafka/zk/KafkaZkClient.scala:
##########
@@ -1723,36 +1722,6 @@ class KafkaZkClient private[zk] (
}
}
- def getOrCreateMigrationState(initialState: ZkMigrationLeadershipState):
ZkMigrationLeadershipState = {
Review Comment:
It looks like `tryRegisterKRaftControllerAsActiveController()` is no longer
called, so it can be deleted too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
