chia7712 commented on code in PR #18016:
URL: https://github.com/apache/kafka/pull/18016#discussion_r1880550240
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1250,8 +1248,7 @@ private void replay(ApiMessage message,
Optional<OffsetAndEpoch> snapshotId, lon
// NoOpRecord is an empty record and doesn't need to be
replayed
break;
case ZK_MIGRATION_STATE_RECORD:
- featureControl.replay((ZkMigrationStateRecord) message);
- break;
+ throw new UnsupportedOperationException("ZK migration is no
longer supported.");
Review Comment:
> Why do you prefer keeping the call to featureControl.replay()?
It is a matter of personal preference. :)
Another reason is that it maintains usage in the production code. Otherwise,
it’s easy to misunderstand and assume, "Oh, this generated code has no
reference in the production code, so we can remove it."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
