mimaison commented on code in PR #18016:
URL: https://github.com/apache/kafka/pull/18016#discussion_r1880482936
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1250,8 +1248,7 @@ private void replay(ApiMessage message,
Optional<OffsetAndEpoch> snapshotId, lon
// NoOpRecord is an empty record and doesn't need to be
replayed
break;
case ZK_MIGRATION_STATE_RECORD:
- featureControl.replay((ZkMigrationStateRecord) message);
- break;
+ throw new UnsupportedOperationException("ZK migration is no
longer supported.");
Review Comment:
Why do you prefer keeping the call to `featureControl.replay()`? This seems
unnecessary. Also I'm not sure whether logging has much value, at least not at
the `info` level, maybe `debug` or `trace` in case you absolutely want to see
all records passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
