mimaison commented on code in PR #18016:
URL: https://github.com/apache/kafka/pull/18016#discussion_r1880459294
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1257,6 +1256,7 @@ private void replay(ApiMessage message,
Optional<OffsetAndEpoch> snapshotId, lon
// NoOpRecord is an empty record and doesn't need to be
replayed
break;
case ZK_MIGRATION_STATE_RECORD:
+ log.info("ZK migration is no longer supported.");
featureControl.replay((ZkMigrationStateRecord) message);
Review Comment:
Do we need to call `featureControl.replay()` here? Could this case be a
no-op?
##########
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##########
@@ -247,6 +252,7 @@ public void replay(ApiMessage record) {
*/
break;
case ZK_MIGRATION_STATE_RECORD:
+ log.info("ZK migration is no longer supported.");
Review Comment:
Same as QuorumController
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
